Core: suspend auctions during prerendering #12763
Conversation
|
lgtm, can we document |
src/prebid.js
Outdated
| pbjsInstance.processQueue = delayIfPrerendering(function () { | ||
| pbjsInstance.que.push = pbjsInstance.cmd.push = quePush; | ||
| insertLocatorFrame(); | ||
| hook.ready(); | ||
| processQueue(pbjsInstance.que); | ||
| processQueue(pbjsInstance.cmd); | ||
| }; | ||
| }); |
There was a problem hiding this comment.
Hi @dgirardi I have a question, since now the processQueue is called when the prebid instance is ready, introducing this change will introduce the delay of all the queues, right?
I understood that the delay was actually only related to the requestBids, and this seems fantastic because we can execute everything in the prerendering "phase" and then firing only the auctions when the user actually views the page.
Can you tell me if I'm wrong? Sorry in advance.
There was a problem hiding this comment.
That's a good suggestion. I defaulted to delaying everything because it seemed safer, but we couldn't think of an example of something that would break if we delayed only auctions. Updated.
Type of change
Description of change
If the document is being prerendered, delay auctions until the page is activated.
Other information
Closes #12724